MINOR: Add explicit exception when no more buffer can be read when loading buffers#649
Merged
viirya merged 1 commit intoapache:mainfrom Mar 4, 2025
Merged
MINOR: Add explicit exception when no more buffer can be read when loading buffers#649viirya merged 1 commit intoapache:mainfrom
viirya merged 1 commit intoapache:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
lidavidm
approved these changes
Mar 4, 2025
Member
Author
Seems CI has some issues? I may not be able to handle it for now. Leave it to others or I can take a look tomorrow. Thanks. |
Member
|
FYI, I'm working on a PR about GitHub Action. It will be available soon and this PR can be rebase after the merge of my PR. |
Member
Author
Thank you @jbonofre |
Member
|
See #650 |
Member
Author
|
Rebased. |
jbonofre
approved these changes
Mar 4, 2025
Member
Author
Member
|
@viirya we are using "merge button", but only committers/PMC members can do that. |
Member
Author
|
Thank you @jbonofre. I merged this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
When
VectorLoadertries to load buffers (i.e.,loadBuffers), it has detect on the error case that some buffers are not consumed. But another error that the number of buffers is less than expected is not handled for now. Once it is happened, users will getjava.util.NoSuchElementExceptionwhich is not easy to understand.This patch adds an explicit exception for such case.
See more discussion at #648.